linux-kernel - Re: [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEk_Sx2qht6WK6yQ@smile.fi.intel.com>
Date: Wed, 11 Jun 2025 11:33:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Waiman Long <longman@...hat.com>,
	Boqun Feng <boqun.feng@...il.com>,
	Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>,
	Will Deacon <will@...nel.org>, Han Xu <han.xu@....com>,
	Haibo Chen <haibo.chen@....com>,
	Yogesh Gaur <yogeshgaur.83@...il.com>, Lee Jones <lee@...nel.org>,
	Pavel Machek <pavel@...nel.org>, Andrew Davis <afd@...com>,
	linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-spi@...r.kernel.org, imx@...ts.linux.dev,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v6 1/3] spi: spi-nxp-fspi: check return value of
 devm_mutex_init()

On Tue, Jun 10, 2025 at 12:46:12PM +0100, Mark Brown wrote:
> On Tue, Jun 10, 2025 at 12:57:37PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 09, 2025 at 09:59:46PM +0100, Mark Brown wrote:
> 
> > > I don't understand the comment about leaking here?  We might end up with
> > > an unitialised mutex but how would we leak anything?
> 
> > In case if the mutex_init() allocates something that needs to be freed
> > (in the future).
> 
> I don't see how checking the return value impacts that?  The management
> via devm is still there either way.

I see now what you mean. Yes, this is more likely applicable to non-devm case.
Thomas, can you adjust the commit message(s), please, for v7?

-- 
With Best Regards,
Andy Shevchenko