linux-kernel - Re: [PATCH 3/6] dt-bindings: power: supply: qcom,pmi8998: Add missing power-supply ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4929c09d-ea3e-4dab-a440-a7d806793d9f@linaro.org>
Date: Wed, 11 Jun 2025 11:01:02 +0200
From: Casey Connolly <casey.connolly@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
 Jakob Hauser <jahau@...ketmail.com>, David Heidelberg <david@...t.cz>,
 Dmitry Osipenko <digetx@...il.com>, Tobias Schrammm <t.schramm@...jaro.org>,
 Linus Walleij <linus.walleij@...aro.org>, Chen-Yu Tsai <wens@...e.org>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: power: supply: qcom,pmi8998: Add missing
 power-supply ref



On 6/4/25 10:18, Krzysztof Kozlowski wrote:
> Reference the common power supply schema to bring the definition of
> monitored-battery property.  Drop also the obvious description because
> it is duplicating what is in power-supply.yaml.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Casey Connolly <casey.connolly@...aro.org>> ---
>   .../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml     | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> index 90c7dc7632c58dc5cbfb3abcde8e730882bfd936..70f5cd6eaeabe822babf567d92b1d7f9124f3680 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> @@ -38,9 +38,7 @@ properties:
>         - const: usbin_i
>         - const: usbin_v
>   
> -  monitored-battery:
> -    description: phandle to the simple-battery node
> -    $ref: /schemas/types.yaml#/definitions/phandle
> +  monitored-battery: true
>   
>   required:
>     - compatible
> @@ -51,6 +49,9 @@ required:
>     - io-channel-names
>     - monitored-battery
>   
> +allOf:
> +  - $ref: power-supply.yaml#
> +
>   additionalProperties: false
>   
>   examples:
> 

-- 
Casey (she/they)