linux-kernel - Re: [PATCH v3 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add audio AFE document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d08cb08c-4bdd-4715-8273-9feb7de7474b@kernel.org>
Date: Wed, 11 Jun 2025 11:32:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Darren.Ye" <darren.ye@...iatek.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: Rob Herring <robh@...nel.org>, linux-sound@...r.kernel.org,
 Linus Walleij <linus.walleij@...aro.org>, devicetree@...r.kernel.org,
 Mark Brown <broonie@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-gpio@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v3 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add
 audio AFE document

On 14/05/2025 12:54, Krzysztof Kozlowski wrote:
> On 14/05/2025 10:11, Darren.Ye wrote:
>> From: Darren Ye <darren.ye@...iatek.com>
>>
>> Add mt8196 audio AFE document.
> 
> A nit, subject: drop second/last, redundant "document".
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Since you asked what did you miss from previous review (and I replied
that EVERYTHING) then maybe this will help:

How did you implement this?

> 
>>
>> Signed-off-by: Darren Ye <darren.ye@...iatek.com>
> 
> 
> ...
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - mediatek,vlpcksys
>> +  - power-domains
>> +  - memory-region
>> +  - clocks
>> +  - clock-names
> 
> 
> Keep the same order as in properties:.

How did you implement this?


> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

How did you implement this?


> 
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
> 
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> of patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is
> "received", when provided in a message replied to you on the mailing
> list. Tools like b4 can help here. However, there's no need to repost
> patches *only* to add the tags. The upstream maintainer will do that for
> tags received on the version they apply.
> 
> Full context and explanation:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

How did you implement this?

Does such questions help you to find what was missing?

Best regards,
Krzysztof