linux-kernel - Re: [PATCH] wifi: zd1211rw: Fix potential data race in zd_mac_tx_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13332646e4c8b028504f6a7ec4a2aa9530c519f1.camel@sipsolutions.net>
Date: Wed, 11 Jun 2025 11:35:18 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Daniil Dulov <d.dulov@...ddin.ru>
Cc: Kees Cook <kees@...nel.org>, Emmanuel Grumbach
 <emmanuel.grumbach@...el.com>,  Miri Korenblit
 <miriam.rachel.korenblit@...el.com>, "John W. Linville"
 <linville@...driver.com>, Daniel Drake	 <dsd@...too.org>,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] wifi: zd1211rw: Fix potential data race in
 zd_mac_tx_to_dev()

Hi,

So ... I have no idea why you're CC'ing all kinds of people who never
had anything to do with this driver, or haven't worked on WiFi in like a
decade or so ... Please don't. Even I should've been CC'ed with a
different address, at most.

I also have no idea who's maintaining this driver now though, if anyone.
I have hardware if someone wants it ;-)

> In order to avoid potential data races and leading dereference of a NULL
> pointer, acquire the queue lock before any work with the queue is done and
> replace all skb_* calls with their lockless version.

You should explain why the locking changes are OK.

johannes