linux-kernel - Re: [PATCH] media: iris: Fix opp scaling of power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9485fe7a-49f3-8cd0-5085-76a9d133045a@quicinc.com>
Date: Wed, 11 Jun 2025 15:09:46 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Akhil P Oommen <akhilpo@....qualcomm.com>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        "Bryan
 O'Donoghue" <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: iris: Fix opp scaling of power domains



On 6/11/2025 11:13 AM, Akhil P Oommen wrote:
> Pass PD_FLAG_REQUIRED_OPP flag to allow opp framework to scale the rpmpd
> power domains.
> 
> Signed-off-by: Akhil P Oommen <akhilpo@....qualcomm.com>

Reviewed-by: Dikshita Agarwal <quic_dikshita@...cinc.com>

Thanks,
Dikshita
> ---
> Found this issue while reviewing the Iris source and only compile tested.
> ---
>  drivers/media/platform/qcom/iris/iris_probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index 9a7ce142f7007ffcda0bd422c1983f2374bb0d92..4e6e92357968d7419f114cc0ffa9b571bad19e46 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -53,7 +53,7 @@ static int iris_init_power_domains(struct iris_core *core)
>  	struct dev_pm_domain_attach_data iris_opp_pd_data = {
>  		.pd_names = core->iris_platform_data->opp_pd_tbl,
>  		.num_pd_names = core->iris_platform_data->opp_pd_tbl_size,
> -		.pd_flags = PD_FLAG_DEV_LINK_ON,
> +		.pd_flags = PD_FLAG_DEV_LINK_ON | PD_FLAG_REQUIRED_OPP,
>  	};
>  
>  	ret = devm_pm_domain_attach_list(core->dev, &iris_pd_data, &core->pmdomain_tbl);
> 
> ---
> base-commit: d9946fe286439c2aeaa7953b8c316efe5b83d515
> change-id: 20250527-iris-opp-fix-3ef2591c032a
> 
> Best regards,