linux-kernel - Re: [PATCH] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aElYnJOpoGbrg-6u@kuha.fi.intel.com>
Date: Wed, 11 Jun 2025 13:21:16 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Tomasz Michalec <tmichalec@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Konrad Adamczyk <konrada@...gle.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, chromeos-krk-upstreaming@...gle.com
Subject: Re: [PATCH] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't
 present

On Tue, Jun 10, 2025 at 05:40:58PM +0200, Tomasz Michalec wrote:
> If pmc_usb_probe is called before SCU IPC is registered, pmc_usb_probe
> will fail.
> 
> Return -EPROBE_DEFER when pmc_usb_probe doesn't get SCU IPC device, so
> the probe function can be called again after SCU IPC is initialized.
> 
> Signed-off-by: Tomasz Michalec <tmichalec@...gle.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux/intel_pmc_mux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
> index 65dda9183e6f..1698428654ab 100644
> --- a/drivers/usb/typec/mux/intel_pmc_mux.c
> +++ b/drivers/usb/typec/mux/intel_pmc_mux.c
> @@ -754,7 +754,7 @@ static int pmc_usb_probe(struct platform_device *pdev)
>  
>  	pmc->ipc = devm_intel_scu_ipc_dev_get(&pdev->dev);
>  	if (!pmc->ipc)
> -		return -ENODEV;
> +		return -EPROBE_DEFER;
>  
>  	pmc->dev = &pdev->dev;
>  
> -- 
> 2.50.0.rc0.604.gd4ff7b7c86-goog

-- 
heikki