linux-kernel - Re: [PATCH v14 4/9] ref_tracker: add a static classname string to each ref_tracker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r3mbkrgrok3yh3txuxmddgezsvvpwnackv725ro4wg3xa323xr@36hii2pcv3gp>
Date: Wed, 11 Jun 2025 10:32:02 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>, Kuniyuki Iwashima <kuniyu@...zon.com>,
	Qasim Ijaz <qasdev00@...il.com>, Nathan Chancellor <nathan@...nel.org>,
	Andrew Lunn <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH v14 4/9] ref_tracker: add a static classname string to
 each ref_tracker_dir

Hi Jeff,

> A later patch in the series will be adding debugfs files for each
> ref_tracker that get created in ref_tracker_dir_init(). The format will
> be "class@%px". The current "name" string can vary between
> ref_tracker_dir objects of the same type, so it's not suitable for this
> purpose.
> 
> Add a new "class" string to the ref_tracker dir that describes the
> the type of object (sans any individual info for that object).
> 
> Also, in the i915 driver, gate the creation of debugfs files on whether
> the dentry pointer is still set to NULL. CI has shown that the
> ref_tracker_dir can be initialized more than once.
> 
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---

Looks good:
Reviewed-by: Krzysztof Karas <krzysztof.karas@...el.com>

A side note:
I was wondering if we could improve naming a bit, but I think it
is not worth the effort. Names like "dptun" instead of
"dp_tunnel" and including "wakeref" only in
__intel_wakeref_init() but not in init_intel_runtime_pm_wakeref()
in "intel_runtime_pm" string stand out, but it is quite clear
what these names mean, so I added my r-b.

Best Regards,
Krzysztof