linux-kernel - Aw: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-cf16c45f-66e1-486f-969f-fb19f722f769-1749638694479@trinity-msg-rest-gmx-gmx-live-847b5f5c86-m27rw>
Date: Wed, 11 Jun 2025 10:44:54 +0000
From: Frank Wunderlich <frank-w@...lic-files.de>
To: angelogioacchino.delregno@...labora.com, linux@...web.de,
 myungjoo.ham@...sung.com, kyungmin.park@...sung.com, cw00.choi@...sung.com,
 djakov@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andrew@...n.ch, olteanv@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, matthias.bgg@...il.com
Cc: jia-wei.chang@...iatek.com, johnson.wang@...iatek.com,
 arinc.unal@...nc9.com, Landen.Chao@...iatek.com, dqfext@...il.com,
 sean.wang@...iatek.com, daniel@...rotopia.org, lorenzo@...nel.org,
 nbd@....name, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Aw: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add
 sfp cages and link to gmac

Hi

> Gesendet: Mittwoch, 11. Juni 2025 um 11:33
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>
> Betreff: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
>
> Il 08/06/25 23:14, Frank Wunderlich ha scritto:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> > 
> > Add SFP cages to Bananapi-R4 board. The 2.5g phy variant only contains the
> > wan-SFP, so add this to common dtsi and the lan-sfp only to the dual-SFP
> > variant.
> > 
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> > ---
> > v3:
> > - enable mac with 2.5g phy on r4 phy variant because driver is now mainline
> > ---
> >   .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts   | 12 ++++++++++++
> >   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts   | 18 ++++++++++++++++++
> >   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi  | 18 ++++++++++++++++++
> >   3 files changed, 48 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > index 53de9c113f60..e63e17ae35a0 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts
> > @@ -9,3 +9,15 @@ / {
> >   	model = "Banana Pi BPI-R4 (1x SFP+, 1x 2.5GbE)";
> >   	chassis-type = "embedded";
> >   };
> > +
> > +&gmac1 {
> 
> phy = ...
> phy-c..onnection-type
> phy-m...ode

phy-connection-type is dropped in next version due to comment from andrew, but i order alphabetically

> > +	phy-mode = "internal";
> > +	phy-connection-type = "internal";
> > +	phy = <&int_2p5g_phy>;
> > +	status = "okay";
> > +};
> > +
> > +&int_2p5g_phy {
> > +	pinctrl-names = "i2p5gbe-led";
> > +	pinctrl-0 = <&i2p5gbe_led0_pins>;
> 
> pinctrl-names
> pinctrl-0

what the difference? i don't see it :(

the others i change in v4

regards Frank