linux-kernel - Re: [PATCH v4 01/10] ASoC: mediatek: common: modify mtk afe platform driver for mt8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cf01f45-ea0b-421e-81a7-163c069aeaf0@collabora.com>
Date: Wed, 11 Jun 2025 13:14:54 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: "Darren.Ye" <darren.ye@...iatek.com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v4 01/10] ASoC: mediatek: common: modify mtk afe platform
 driver for mt8196

Il 10/06/25 11:27, Darren.Ye ha scritto:
> From: Darren Ye <darren.ye@...iatek.com>
> 
> Mofify the pcm pointer interface to support 64-bit address access.
> 
> Signed-off-by: Darren Ye <darren.ye@...iatek.com>
> ---
>   .../mediatek/common/mtk-afe-platform-driver.c | 47 ++++++++++++-------
>   .../mediatek/common/mtk-afe-platform-driver.h |  2 +
>   2 files changed, 33 insertions(+), 16 deletions(-)
> 
> diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.c b/sound/soc/mediatek/common/mtk-afe-platform-driver.c
> index 6b6330583941..a86594dca2b7 100644
> --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.c
> +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.c

..snip..

> diff --git a/sound/soc/mediatek/common/mtk-afe-platform-driver.h b/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> index fcc923b88f12..9809e60db511 100644
> --- a/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> +++ b/sound/soc/mediatek/common/mtk-afe-platform-driver.h
> @@ -12,6 +12,8 @@
>   #define AFE_PCM_NAME "mtk-afe-pcm"
>   extern const struct snd_soc_component_driver mtk_afe_pcm_platform;
>   
> +#define MTK_WORD_SIZE_ALIGN(x) ((x) & (0xfffffffff0))

This doesn't really look like alignment to me, so perhaps change the macro name.
Also, please use the GENMASK macro.

0xfffffffff0 -> GENMASK(39, 4)

after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> +
>   struct mtk_base_afe;
>   struct snd_pcm;
>   struct snd_soc_component;