linux-kernel - Re: [PATCH net-next 4/4] net: mana: Handle unsupported HWC commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611113539.GB4690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Wed, 11 Jun 2025 04:35:39 -0700
From: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	kotaranov@...rosoft.com, longli@...rosoft.com, horms@...nel.org,
	shirazsaleem@...rosoft.com, leon@...nel.org,
	shradhagupta@...ux.microsoft.com, schakrabarti@...ux.microsoft.com,
	rosenp@...il.com, sdf@...ichev.me, linux-hyperv@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] net: mana: Handle unsupported HWC commands

On Wed, Jun 11, 2025 at 01:46:16AM -0700, Erni Sri Satya Vennela wrote:
> If any of the HWC commands are not recognized by the
> underlying hardware, the hardware returns the response
> header status of -1. Log the information using
> netdev_info_once to avoid multiple error logs in dmesg.
> 
> Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Reviewed-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> ---
>  drivers/net/ethernet/microsoft/mana/hw_channel.c |  4 ++++
>  drivers/net/ethernet/microsoft/mana/mana_en.c    | 11 +++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> index a8c4d8db75a5..70c3b57b1e75 100644
> --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> @@ -890,6 +890,10 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
>  	}
>  
>  	if (ctx->status_code && ctx->status_code != GDMA_STATUS_MORE_ENTRIES) {
> +		if (ctx->status_code == -1) {
Minor comment: instead of == -1 could use some macro like GDMA_STATUS_CMD_UNSUPPORTED, rest LGTM.

> +			err = -EOPNOTSUPP;
> +			goto out;
> +		}
>  		dev_err(hwc->dev, "HWC: Failed hw_channel req: 0x%x\n",
>  			ctx->status_code);
>  		err = -EPROTO;
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index d5644400e71f..10e766c73fca 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -847,6 +847,9 @@ static int mana_send_request(struct mana_context *ac, void *in_buf,
>  	err = mana_gd_send_request(gc, in_len, in_buf, out_len,
>  				   out_buf);
>  	if (err || resp->status) {
> +		if (err == -EOPNOTSUPP)
> +			return err;
> +
>  		dev_err(dev, "Failed to send mana message: %d, 0x%x\n",
>  			err, resp->status);
>  		return err ? err : -EPROTO;
> @@ -1251,6 +1254,10 @@ int mana_query_link_cfg(struct mana_port_context *apc)
>  				sizeof(resp));
>  
>  	if (err) {
> +		if (err == -EOPNOTSUPP) {
> +			netdev_info_once(ndev, "MANA_QUERY_LINK_CONFIG not supported\n");
> +			return err;
> +		}
>  		netdev_err(ndev, "Failed to query link config: %d\n", err);
>  		return err;
>  	}
> @@ -1293,6 +1300,10 @@ int mana_set_bw_clamp(struct mana_port_context *apc, u32 speed,
>  				sizeof(resp));
>  
>  	if (err) {
> +		if (err == -EOPNOTSUPP) {
> +			netdev_info_once(ndev, "MANA_SET_BW_CLAMP not supported\n");
> +			return err;
> +		}
>  		netdev_err(ndev, "Failed to set bandwidth clamp for speed %u, err = %d",
>  			   speed, err);
>  		return err;
> -- 
> 2.34.1
>

Reviewed-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>