linux-kernel - Re: [PATCH v2 05/18] KVM: x86: Move PIT ioctl helpers to i8254.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c90e3ceba8a47b2139e3393c44e582c5a7b7d151.camel@intel.com>
Date: Thu, 12 Jun 2025 02:09:47 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 05/18] KVM: x86: Move PIT ioctl helpers to i8254.c

On Wed, 2025-06-11 at 14:35 -0700, Sean Christopherson wrote:
> Move the PIT ioctl helpers to i8254.c, i.e. to the file that implements
> PIT emulation.  Eliminating PIT code in x86.c will allow adding a Kconfig
> to control support for in-kernel I/O APIC, PIC, and PIT emulation with
> minimal #ifdefs.

And it matches the other (existing) ioctl helpers which are under
CONFIG_KVM_HYPERV [*] and CONFIG_KVM_XEN too.

[*]:  The kvm_ioctl_get_supported_hv_cpuid() seems to be the only one that
still remains in kvm/x86.c but not in kvm/hyperv.c.

> 
> Opportunistically make kvm_pit_set_reinject() and kvm_pit_load_count()
> local to i8254.c as they were only publicly visible to make them available
> to the ioctl helpers.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---

Acked-by: Kai Huang <kai.huang@...el.com>