linux-kernel - Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8stpis6RuFZ8X+g=nnQhQQNJN8X8kpma6kf2Hmi+3hf4w@mail.gmail.com>
Date: Thu, 12 Jun 2025 14:24:37 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable
 USB2.0 support

Hi Geert,

Thank you for the review.

On Thu, Jun 12, 2025 at 1:49 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> > supports host/function operation.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > @@ -302,6 +317,16 @@ sd1-dat-cmd {
> >                         slew-rate = <0>;
> >                 };
> >         };
> > +
> > +       usb20_pins: usb20 {
> > +               ovc {
> > +                       pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */
>
> Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
> not on RZ/V2N EVK?
>
On the RZ/V2N EVK for the USB20_OVRCUR pin we have R13110K0603 pullup
resistor, this was missing on the earlier version of the RZ/V2H EVK
due to which we saw false OC condition (as seen below). Said that the
actual EVKs for RZ/V2H for which support is being added do have this
pullup resistor. After testing I will post a patch to drop the
`bias-pull-up` property from the RZ/V2H DTS (thanks for reminding me
:-)).

[    2.672424] usb usb3-port1: over-current condition
[    2.792424] usb usb4-port1: over-current condition

Cheers,
Prabhakar