linux-kernel - Re: [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <935f3127-8304-481a-91f8-fbce02197e07@lucifer.local>
Date: Thu, 12 Jun 2025 14:31:05 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: David Hildenbrand <david@...hat.com>
Cc: Baolin Wang <baolin.wang@...ux.alibaba.com>, akpm@...ux-foundation.org,
        hughd@...gle.com, Liam.Howlett@...cle.com, npache@...hat.com,
        ryan.roberts@....com, dev.jain@....com, ziy@...dia.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mm: huge_memory: disallow hugepages if the
 system-wide THP sysfs settings are disabled

On Thu, Jun 12, 2025 at 03:13:19PM +0200, David Hildenbrand wrote:
[snip]
>
> The masks are just disgusting :(

Yeah I was shocked when I saw this implementation it's bloody terrible. It just
is.

>
> While you were writing that reply, I just sent out something else. Not sure
> if that makes sense.

Replied there :>)

>
> I'm having a hard time figuring out what we even want here in the existing
> code.

I'm confused as to why this has been done in this way in general.

I feel a churny refactoring coming on... ;)

>
> --
> Cheers,
>
> David / dhildenb
>