linux-kernel - Re: [PATCH v2 4/7] irqchip: MIPS P800 variant of aclint-sswi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS2PR09MB6296B52C0B28C0ACF9D3D5E49474A@AS2PR09MB6296.eurprd09.prod.outlook.com>
Date: Thu, 12 Jun 2025 14:38:35 +0000
From: Vladimir Kondratiev <Vladimir.Kondratiev@...ileye.com>
To: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
	<palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti
	<alex@...ti.fr>, Anup Patel <anup@...infault.org>, Chen Wang
	<unicorn_wang@...look.com>, Inochi Amaoto <inochiama@...il.com>, Sunil V L
	<sunilvl@...tanamicro.com>, "Rafael J . Wysocki"
	<rafael.j.wysocki@...el.com>, Ryo Takakura <takakura@...inux.co.jp>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"sophgo@...ts.linux.dev" <sophgo@...ts.linux.dev>
Subject: Re: [PATCH v2 4/7] irqchip: MIPS P800 variant of aclint-sswi

>> +config ACLINT_SSWI
>> +     bool
>> +
>> +config MIPS_P8700_ACLINT_SSWI
>> +     bool "MIPS P8700 ACLINT S-mode IPI Interrupt Controller"
>> +     depends on RISCV
>> +     depends on SMP
>> +     select IRQ_DOMAIN_HIERARCHY
>> +     select GENERIC_IRQ_IPI_MUX
>> +     select ACLINT_SSWI
>> +     help
>> +       This enables support for MIPS P8700 specific ACLINT SSWI device
>> +
>> +       If you don't know what to do here, say Y.
>> +
>>  config THEAD_C900_ACLINT_SSWI
>>        bool "THEAD C9XX ACLINT S-mode IPI Interrupt Controller"
>>        depends on RISCV
>>        depends on SMP
>>        select IRQ_DOMAIN_HIERARCHY
>>        select GENERIC_IRQ_IPI_MUX
>> +     select ACLINT_SSWI
>>        help
>>          This enables support for T-HEAD specific ACLINT SSWI device
>>          support.
>
>That's just exactly the same thing twice for no value. Just rename it to
>ACLINT_SSWI and have a list of supported chips in the help text.
>
>The only issue with the rename is, that oldconfig will drop the then
>non-existing THEAD_C900_ACLINT_SSWI entry in the previous config. That's
>not the end of the world and if really desired this can be solved by
>having:
>
>config ACLINT_SSWI
>        bool "RISCV ACLINT ...."
>        depends on RISCV
>        depends on SMP
>        select IRQ_DOMAIN_HIERARCHY
>        select GENERIC_IRQ_IPI_MUX
>        select ACLINT_SSWI
>        help
>          This enables support for ACLINT SSWI device on THEAD C9XX and
>          MIPS P8700 devices.
>
># Backwards compatibility so oldconfig does not drop it.
>config THEAD_C900_ACLINT_SSWI
>        select ACLINT_SSWI

Thanks, doing this. Indeed it is more compact and clean.
Submitting v3