linux-kernel - Re: [PATCH 2/2] vhost-scsi: Improve error handling in vhost_scsi_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60653628-3078-43dd-9a51-5fd46be6f74a@oracle.com>
Date: Wed, 11 Jun 2025 21:29:03 -0500
From: michael.christie@...cle.com
To: Alok Tiwari <alok.a.tiwari@...cle.com>, mst@...hat.com,
        jasowang@...hat.com, pbonzini@...hat.com, stefanha@...hat.com,
        eperezma@...hat.com, virtualization@...ts.linux.dev,
        kvm@...r.kernel.org
Cc: darren.kenny@...cle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] vhost-scsi: Improve error handling in
 vhost_scsi_make_nexus and tpg

On 6/11/25 9:39 AM, Alok Tiwari wrote:
> Use PTR_ERR to return the actual error code when vhost_scsi_make_nexus
> fails to create a session, instead of returning -ENOMEM.
> This ensures more accurate error propagation.
> 
> Replace NULL with ERR_PTR(ret) in vhost_scsi_make_tpg to follow kernel
> conventions for pointer-returning functions, allowing callers to use
> IS_ERR and PTR_ERR for proper error handling.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Mike Christie <michael.christie@...cle.com>