linux-kernel - Re: [PATCH net-next v3 1/4] udp_tunnel: remove rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250612073929.151fe6bf@kernel.org>
Date: Thu, 12 Jun 2025 07:39:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, skalluru@...vell.com, manishc@...vell.com,
 andrew+netdev@...n.ch, michael.chan@...adcom.com,
 pavan.chebbi@...adcom.com, ajit.khaparde@...adcom.com,
 sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
 anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
 tariqt@...dia.com, saeedm@...dia.com, louis.peens@...igine.com,
 shshaikh@...vell.com, GR-Linux-NIC-Dev@...vell.com, ecree.xilinx@...il.com,
 horms@...nel.org, dsahern@...nel.org, shuah@...nel.org,
 ruanjinjie@...wei.com, mheib@...hat.com, linux-kernel@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
 oss-drivers@...igine.com, linux-net-drivers@....com,
 linux-kselftest@...r.kernel.org, leon@...nel.org, Cosmin Ratiu
 <cratiu@...dia.com>
Subject: Re: [PATCH net-next v3 1/4] udp_tunnel: remove rtnl_lock dependency

On Wed, 11 Jun 2025 19:47:54 -0700 Stanislav Fomichev wrote:
> > There are multiple entry points to this code, basically each member of
> > struct udp_tunnel_nic_ops and the netdev notifiers. In this patch only
> > reset and work are locked. I'm a bit confused as to what is the new
> > lock protecting :S  
> 
> I though that most of the callers are from do_setlink and there we have
> rtnl and we grab rtnl+lock during the sync. But that doesn't
> address the suspend/resume vs do_setlink race, that's true :-(

It's the UDP tunnels that add and remove the ports usually.