linux-kernel - Re: [PATCH 3/8] dt-bindings: clock: renesas,cpg-mssr: Document RZ/N2H support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVvQEC9c9wHDrFiY6iixuP-JjOgHZQjfzOkAjvxs=LuqQ@mail.gmail.com>
Date: Thu, 12 Jun 2025 16:37:52 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, linux-renesas-soc@...r.kernel.org, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 3/8] dt-bindings: clock: renesas,cpg-mssr: Document RZ/N2H support

Hi Prabhakar,

Thanks for your patch!

On Mon, 9 Jun 2025 at 22:37, Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Document support for Module Standby and Software Reset found on the

the Clock Generator and Module Standby and Software Reset

> Renesas RZ/N2H (R9A09G087) SoC. The Module Standby and Software Reset IP

Clock Generator and ...

> is similar to that found on the RZ/T2H SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

> --- /dev/null
> +++ b/include/dt-bindings/clock/renesas,r9a09g087-cpg-mssr.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * Copyright (C) 2025 Renesas Electronics Corp.
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_RENESAS_R9A09G087_CPG_H__
> +#define __DT_BINDINGS_CLOCK_RENESAS_R9A09G087_CPG_H__
> +
> +#include <dt-bindings/clock/renesas-cpg-mssr.h>
> +
> +/* R9A09G087 CPG Core Clocks */
> +#define R9A09G087_CLK_CA55C0           0
> +#define R9A09G087_CLK_CA55C1           1
> +#define R9A09G087_CLK_CA55C2           2
> +#define R9A09G087_CLK_CA55C3           3
> +#define R9A09G087_CLK_CA55S            4
> +#define R9A09G087_CLK_CR52_CPU0                5
> +#define R9A09G087_CLK_CR52_CPU1                6
> +#define R9A09G087_CLK_CKIO             7
> +#define R9A09G087_CLK_PCLKAH           8
> +#define R9A09G087_CLK_PCLKAM           9
> +#define R9A09G087_CLK_PCLKAL           10
> +#define R9A09G087_CLK_PCLKGPTL         11
> +#define R9A09G087_CLK_PCLKH            12
> +#define R9A09G087_CLK_PCLKM            13
> +#define R9A09G087_CLK_PCLKL            14

The RZ/T2H DT bindings file lacks PCLKL, which was probably a harmless
oversight (it can always be added later), as it does exist on RZ/T2H,
too, according to the documentation.

However, given drivers/clk/renesas/r9a09g077-cpg.c has
LAST_DT_CORE_CLK = R9A09G077_CLK_PCLKM,
using R9A09G087_CLK_PCLKL will lead to wrong results.

So either you want to add R9A09G077_CLK_PCLKL and update
LAST_DT_CORE_CLK first, or set LAST_DT_CORE_CLK to R9A09G087_CLK_PCLKL
in this patch.

> +
> +#endif /* __DT_BINDINGS_CLOCK_RENESAS_R9A09G087_CPG_H__ */

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds