linux-kernel - Re: [PATCH] hns3: work around stack size warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ad6c3eb7-22d9-4f81-8656-a1f62aba3b4d@app.fastmail.com>
Date: Thu, 12 Jun 2025 17:27:02 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jakub Kicinski" <kuba@...nel.org>
Cc: "Jijie Shao" <shaojijie@...wei.com>, "Arnd Bergmann" <arnd@...nel.org>,
 "Jian Shen" <shenjian15@...wei.com>, "Salil Mehta" <salil.mehta@...wei.com>,
 "Andrew Lunn" <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Paolo Abeni" <pabeni@...hat.com>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <nick.desaulniers+lkml@...il.com>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt" <justinstitt@...gle.com>,
 "Hao Lan" <lanhao@...wei.com>, "Guangwei Zhang" <zhangwangwei6@...wei.com>,
 Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH] hns3: work around stack size warning

On Thu, Jun 12, 2025, at 16:32, Jakub Kicinski wrote:
> On Thu, 12 Jun 2025 21:09:40 +0800 Jijie Shao wrote:
>> > The normal way of doing this would be to use the infrastructure
>> > from seq_file and then seq_printf() and not have any extra buffers
>> > on top of that.
>> 
>> seq_file is good. But the change is quite big.
>> I need to discuss it internally, and it may not be completed so quickly.
>> I will also need consider the maintainer's suggestion.
>
> Arnd, do you mind waiting? We can apply your patch as is if the warning
> is a nuisance.

It's not urgent, as the current warning limit is still 2048 bytes
for 64-bit targets. I am hoping to have all patches in place for
the next merge window to be able to reduce the default limit to
1280 bytes and I can just carry my local fix for my own testing
until then.

    Arnd