linux-kernel - Re: [cocci] [PATCH v?] coccinelle: misc: secs_to_jiffies: Implement context and report modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42bc5a8c-1b3d-46cf-a8d8-1b54ebf5ecbb@web.de>
Date: Thu, 12 Jun 2025 18:08:51 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>, cocci@...ia.fr
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>, Jakub Kicinski <kuba@...nel.org>,
 Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas Palix <nicolas.palix@...g.fr>,
 Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [cocci] [PATCH v?] coccinelle: misc: secs_to_jiffies: Implement
 context and report modes

>> ---
>> scripts/coccinelle/misc/secs_to_jiffies.cocci | 49 +++++++++++++++++--
…

Did you overlook the addition of patch version descriptions?
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15#n310

Will any information from previous patch review approaches trigger more desirable effects
also for such an SmPL script variant?

>> -@...ends on patch@ constant C; @@
>> +@...nst depends on patch@ constant C; @@
>>  
>>  - msecs_to_jiffies(C * 1000)
>>  + secs_to_jiffies(C)
>>  
>> -@...ends on patch@ constant C; @@
>> +@...nstms depends on patch@ constant C; @@
>>  
>>  - msecs_to_jiffies(C * MSEC_PER_SEC)
>>  + secs_to_jiffies(C)
>>  
>> -@...ends on patch@ expression E; @@
>> +@...pr depends on patch@ expression E; @@
>>  
>>  - msecs_to_jiffies(E * 1000)
>>  + secs_to_jiffies(E)
>>  
>> -@...ends on patch@ expression E; @@
>> +@...prms depends on patch@ expression E; @@
>>  
>>  - msecs_to_jiffies(E * MSEC_PER_SEC)
>>  + secs_to_jiffies(E)

Please reduce duplicate code for such SmPL rules.

>> +@r depends on report && !patch@
…

Please reconsider the condition selection once more.
SmPL code can probably be shared between the operation modes “orq” and “report”.
Would you get further development ideas from previous contributions?

Regards,
Markus