linux-kernel - Re: [PATCH] tracing, AER: Hide PCIe AER event when PCIEAER is not configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250612161452.GAaEr8/PdA2jeKC7ld@fat_crate.local>
Date: Thu, 12 Jun 2025 16:14:52 +0000
From: Borislav Petkov <bp@...en8.de>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
	Linux trace kernel <linux-trace-kernel@...r.kernel.org>,
	linux-edac@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] tracing, AER: Hide PCIe AER event when PCIEAER is not
 configured

On Thu, Jun 12, 2025 at 09:49:32AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The event aer_event is only used when CONFIG_PCIEAER is configured. It
> should not be created when it is not. When an event is created it creates
> around 5K of text and meta data regardless if the tracepoint is used or
> not. Instead of wasting this memory, put #ifdef around the event to not
> create it when it is not used.
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
> Note, I will be adding code soon that will make unused events cause a warning.
> 
>  include/ras/ras_event.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
> index 14c9f943d53f..c8cd0f00c845 100644
> --- a/include/ras/ras_event.h
> +++ b/include/ras/ras_event.h
> @@ -252,6 +252,7 @@ TRACE_EVENT(non_standard_event,
>  		  __print_hex(__get_dynamic_array(buf), __entry->len))
>  );
>  
> +#ifdef CONFIG_PCIEAER
>  /*
>   * PCIe AER Trace event
>   *
> @@ -337,6 +338,7 @@ TRACE_EVENT(aer_event,
>  			__print_array(__entry->tlp_header, PCIE_STD_MAX_TLP_HEADERLOG, 4) :
>  			"Not available")
>  );
> +#endif /* CONFIG_PCIEAER */
>  
>  /*
>   * memory-failure recovery action result event
> -- 

Acked-by: Borislav Petkov (AMD) <bp@...en8.de>