linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: mediatek: add mt8173-hana rev2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a1312fbafe65b3fbd2ed7a1fb9f618654fc5d59.camel@icenowy.me>
Date: Fri, 13 Jun 2025 00:11:44 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, 
 Rafa�0�0 Mi�0�0ecki <rafal@...ecki.pl>, Chen-Yu Tsai
 <wenst@...omium.org>, Sean Wang <sean.wang@...iatek.com>,
 devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,  linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: mediatek: add mt8173-hana rev2

在 2025-06-12星期四的 16:34 +0100，Conor Dooley写道：
> On Thu, Jun 12, 2025 at 09:55:58PM +0800, Icenowy Zheng wrote:
> > My Lenovo Flex 11 Chromebook contains a board with revision ID 2.
> > 
> > Add rev2 to the compatible list of base hana DTB to allow
> > depthcharge to
> > match the DTB.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > ---
> >  Documentation/devicetree/bindings/arm/mediatek.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 108ae5e0185d9..7d13547ff57ba 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -132,6 +132,7 @@ properties:
> >            - const: google,hana-rev5
> >            - const: google,hana-rev4
> >            - const: google,hana-rev3
> > +          - const: google,hana-rev2
> 
> Ordinarily I would complain about inserting a compatible like this
> being a problem, but these chromebooks are all cocked up so w/e
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Yes, the DepthCharge bootloader seems to have some different
understanding of root node's compatible -- it just generates
"google,${device}{-rev${rev},}{-sku${sku},}" and match them in the DT's
to get the most compatible DT.

BTW I checked the Chromium OS hana DT, it lists down to rev0, but what
I get is just rev2, so I just added rev2.

> 
> >            - const: google,hana
> >            - const: mediatek,mt8173
> >        - description: Google Hana rev7 (Poin2 Chromebook 11C)
> > -- 
> > 2.49.0
> >