linux-kernel - Re: [cocci] [PATCH v4 1/5] coccinelle: misc: Add field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77406d43-230f-4690-b306-4d698449c01b@web.de>
Date: Thu, 12 Jun 2025 18:48:25 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Luo Jie <quic_luoj@...cinc.com>, cocci@...ia.fr
Cc: LKML <linux-kernel@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
 Andrew Lunn <andrew@...n.ch>, Catalin Marinas <catalin.marinas@....com>,
 Joey Gouly <joey.gouly@....com>, Julia Lawall <Julia.Lawall@...ia.fr>,
 "Kiran Kumar C.S.K" <quic_kkumarcs@...cinc.com>,
 Lei Wei <quic_leiwei@...cinc.com>, Marc Zyngier <maz@...nel.org>,
 Nicolas Palix <nicolas.palix@...g.fr>, Oliver Upton
 <oliver.upton@...ux.dev>, Pavithra R <quic_pavir@...cinc.com>,
 Rasmus Villemoes <linux@...musvillemoes.dk>,
 Suruchi Agarwal <quic_suruchia@...cinc.com>,
 Suzuki Poulose <suzuki.poulose@....com>, Will Deacon <will@...nel.org>,
 Yury Norov <yury.norov@...il.com>, Zenghui Yu <yuzenghui@...wei.com>,
 quic_linchen@...cinc.com
Subject: Re: [cocci] [PATCH v4 1/5] coccinelle: misc: Add field_modify script

…
> ---
>  scripts/coccinelle/misc/field_modify.cocci | 61 ++++++++++++++++++++++++++++++
…

Did you overlook the addition of patch version descriptions?
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15#n310


…
> +@ depends on context && !patch && !org && !report@
…

I imagine that the condition selections can be simplified.


…
> +@...ipt:python depends on report@
> +p << r.p;
> +x << r.reg;
> +@@
> +
> +msg="WARNING: Consider using FIELD_MODIFY helper on %s" % (x)
> +coccilib.report.print_report(p[0], msg)
Do you know that a string construction can also be directly passed
to such a function call?

Regards,
Markus