linux-kernel - [PATCH v2] scripts/sorttable: Handle mmap() failure gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250612-sorttable-fix-v2-1-9cbb747e6b6d@rbox.co>
Date: Thu, 12 Jun 2025 18:55:09 +0200
From: Michal Luczaj <mhal@...x.co>
To: Steven Rostedt <rostedt@...dmis.org>, 
 "Peter Zijlstra (Intel)" <peterz@...radead.org>, 
 Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Michal Luczaj <mhal@...x.co>
Subject: [PATCH v2] scripts/sorttable: Handle mmap() failure gracefully

When mmap() fails, don't propagate MAP_FAILED as a return value. Caller
expects NULL on error.

Fixes: 3c47b787b651 ("scripts/sortextable: Rewrite error/success handling")
Signed-off-by: Michal Luczaj <mhal@...x.co>
---
...
  LD      vmlinux
  BTFIDS  vmlinux
  NM      System.map
  SORTTAB vmlinux
Could not mmap file: vmlinux
scripts/link-vmlinux.sh: line 200:  2688 Segmentation fault      (core dumped) ${objtree}/scripts/sorttable ${1}
Failed to sort kernel tables
---
Changes in v2:
- Rebase, resend
- Link to v1: https://lore.kernel.org/r/20240726-sorttable-fix-v1-1-8b5ba4c4471f@rbox.co
---
 scripts/sorttable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index deed676bfe384deb0333b6dde78c60bc3c6622da..2fe0974b53719b5660e1053af438ad098cdcaf28 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -334,6 +334,7 @@ static void *mmap_file(char const *fname, size_t *size)
 	addr = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
 	if (addr == MAP_FAILED) {
 		fprintf(stderr, "Could not mmap file: %s\n", fname);
+		addr = NULL;
 		goto out;
 	}
 

---
base-commit: 9cc7d5904bab74f54aad4948a04535c1f07c74d8
change-id: 20240723-sorttable-fix-08b9ce81db32

Best regards,
-- 
Michal Luczaj <mhal@...x.co>