linux-kernel - Re: [PATCH] (drivers/ethernet/atheros/atl1) test DMA mapping for error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz5gyitp.fsf@posteo.net>
Date: Thu, 12 Jun 2025 17:24:02 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Chris Snook <chris.snook@...il.com>,  Andrew Lunn
 <andrew+netdev@...n.ch>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Ingo Molnar <mingo@...nel.org>,  Thomas
 Gleixner <tglx@...utronix.de>,  netdev@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] (drivers/ethernet/atheros/atl1) test DMA mapping for
 error code

Thomas Fourier <fourier.thomas@...il.com> writes:

> According to Shuah Khan[1], all `dma_map()` functions should be tested
> before using the pointer. This patch checks for errors in `dma_map()`
> calls and in case of failure, unmaps the previously dma_mapped regions
> and returns an error.
>
> [1] https://events.static.linuxfound.org/sites/events/files/slides/Shuah_Khan_dma_map_error.pdf
>
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
>  drivers/net/ethernet/atheros/atlx/atl1.c | 38 ++++++++++++++++++++++--
>  1 file changed, 36 insertions(+), 2 deletions(-)
> [...]

Hi Thomas,

This doesn't seem to build. You can also see it here[1].

[1]: https://patchwork.kernel.org/project/netdevbpf/patch/20250612150542.85239-2-fourier.thomas@gmail.com/