linux-kernel - Re: [PATCH] xfs: actually use the xfs_growfs_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250612140027.6655d6ed@batman.local.home>
Date: Thu, 12 Jun 2025 14:00:27 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Carlos Maiolino <cem@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
 linux-xfs@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] xfs: actually use the xfs_growfs_check_rtgeom
 tracepoint

On Thu, 12 Jun 2025 10:51:12 -0700
"Darrick J. Wong" <djwong@...nel.org> wrote:

> From: Darrick J. Wong <djwong@...nel.org>
> 
> We created a new tracepoint but forgot to put it in.  Fix that.
> 
> Cc: rostedt@...dmis.org
> Cc: <stable@...r.kernel.org> # v6.14
> Fixes: 59a57acbce282d ("xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs")

May want to also add:

Reported-by: Steven Rostedt <rostedt@...dmis.org>
Closes: https://lore.kernel.org/all/20250612131021.114e6ec8@batman.local.home/

Thanks,

-- Steve

> Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
> ---
>  fs/xfs/xfs_rtalloc.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 6484c596eceaf2..736eb0924573d3 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -1259,6 +1259,8 @@ xfs_growfs_check_rtgeom(
>  
>  	kfree(nmp);
>  
> +	trace_xfs_growfs_check_rtgeom(mp, min_logfsbs);
> +
>  	if (min_logfsbs > mp->m_sb.sb_logblocks)
>  		return -EINVAL;
>