linux-kernel - [PATCH RESEND linux next] signal: Update the comment on __send_signal_locked() in do_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250612115726263u9zKGGhkQXNFUB3OQZqCR@zte.com.cn>
Date: Thu, 12 Jun 2025 11:57:26 +0800 (CST)
From: <jiang.kun2@....com.cn>
To: <oleg@...hat.com>, <tglx@...utronix.de>, <frederic@...nel.org>,
        <peterz@...radead.org>, <brauner@...nel.org>,
        <viro@...iv.linux.org.uk>, <joel.granados@...nel.org>,
        <lorenzo.stoakes@...cle.com>, <linux-kernel@...r.kernel.org>
Cc: <xu.xin16@....com.cn>, <yang.yang29@....com.cn>, <fan.yu9@....com.cn>,
        <qiu.yutan@....com.cn>
Subject: [PATCH RESEND linux next] signal: Update the comment on __send_signal_locked() in
 do_notify_parent()

From: Qiu Yutan <qiu.yutan@....com.cn>

Update the comments for the call to __send_signal_locked()
in do_notify_parent() based on community discussions.

Suggested-by: Oleg Nesterov <oleg@...hat.com>
Signed-off-by: Qiu Yutan <qiu.yutan@....com.cn>
Signed-off-by: Fan Yu <fan.yu9@....com.cn>
Signed-off-by: Jiang Kun <jiang.kun2@....com.cn>
---
 kernel/signal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 148082db9a55..45dc60f8b833 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2252,8 +2252,8 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 			sig = 0;
 	}
 	/*
-	 * Send with __send_signal as si_pid and si_uid are in the
-	 * parent's namespaces.
+	 * Use __send_signal_locked() instead of send_signal_locked()
+	 * because the latter can wrongly change si_pid/si_uid
 	 */
 	if (valid_signal(sig) && sig)
 		__send_signal_locked(sig, &info, tsk->parent, PIDTYPE_TGID, false);
-- 
2.25.1