linux-kernel - Re: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506130217.6OQ8zSf5-lkp@intel.com>
Date: Fri, 13 Jun 2025 02:15:14 +0800
From: kernel test robot <lkp@...el.com>
To: Chiang Brian <chiang.brian@...entec.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Jonathan Corbet <corbet@....net>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
Cc: oe-kbuild-all@...ts.linux.dev, Chiang Brian <chiang.brian@...entec.com>,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685

Hi Chiang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on groeck-staging/hwmon-next krzk-dt/for-next linus/master v6.16-rc1 next-20250612]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chiang-Brian/hwmon-pmbus-tps53679-Add-support-for-TPS53685/20250610-192612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250610102556.236300-3-chiang.brian%40inventec.com
patch subject: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685
config: s390-randconfig-r073-20250611 (https://download.01.org/0day-ci/archive/20250613/202506130217.6OQ8zSf5-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506130217.6OQ8zSf5-lkp@intel.com/

smatch warnings:
drivers/hwmon/pmbus/tps53679.c:288 tps53679_probe() warn: inconsistent indenting

vim +288 drivers/hwmon/pmbus/tps53679.c

   249	
   250	static int tps53679_probe(struct i2c_client *client)
   251	{
   252		struct device *dev = &client->dev;
   253		struct pmbus_driver_info *info;
   254		enum chips chip_id;
   255	
   256		if (dev->of_node)
   257			chip_id = (uintptr_t)of_device_get_match_data(dev);
   258		else
   259			chip_id = i2c_match_id(tps53679_id, client)->driver_data;
   260	
   261		info = devm_kmemdup(dev, &tps53679_info, sizeof(*info), GFP_KERNEL);
   262		if (!info)
   263			return -ENOMEM;
   264	
   265		switch (chip_id) {
   266		case tps53647:
   267		case tps53667:
   268			info->pages = TPS53647_PAGE_NUM;
   269			info->identify = tps53679_identify;
   270			break;
   271		case tps53676:
   272			info->identify = tps53676_identify;
   273			break;
   274		case tps53679:
   275		case tps53688:
   276			info->pages = TPS53679_PAGE_NUM;
   277			info->identify = tps53679_identify;
   278			break;
   279		case tps53681:
   280			info->pages = TPS53679_PAGE_NUM;
   281			info->phases[0] = 6;
   282			info->identify = tps53681_identify;
   283			info->read_word_data = tps53681_read_word_data;
   284			break;
   285		case tps53685:
   286		    info->pages = TPS53679_PAGE_NUM;
   287		    info->identify = tps53685_identify;
 > 288			break;
   289		default:
   290			return -ENODEV;
   291		}
   292	
   293		return pmbus_do_probe(client, info);
   294	}
   295	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki