linux-kernel - Re: [PATCH v3 4/5] iio: amplifiers: ada4250: move offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeewKdOQk9qoO-2Ann90hwAGE0goOtiOG9BRjJ4cn6h=g@mail.gmail.com>
Date: Thu, 12 Jun 2025 21:34:07 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Antoniu Miclaus <antoniu.miclaus@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] iio: amplifiers: ada4250: move offset_uv in struct

On Thu, Jun 12, 2025 at 6:31 PM David Lechner <dlechner@...libre.com> wrote:
> On 6/12/25 8:04 AM, Andy Shevchenko wrote:
> > On Wed, Jun 11, 2025 at 04:33:04PM -0500, David Lechner wrote:
> >> Move offset_uv in struct ada4250_state. This keeps things logically
> >> grouped and reduces holes in the struct.
> >
> > Can the (smallest part of) the diff for `pahole` runs be added here?
>
> Well, I didn't use pahole. I could just tell by looking at it. There
> was int followed by two u8 followed by int, so we know there was a 2
> byte hole before the last int.

Yes, but since we have a tool for such cases, why not use it?

-- 
With Best Regards,
Andy Shevchenko