linux-kernel - Re: [PATCH] wifi: iwlwifi: pcie: ensure RX_QUEUE_CB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ee7559eb-c26b-47c0-bf4c-f710e010a21b@app.fastmail.com>
Date: Thu, 12 Jun 2025 21:48:41 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Anders Roxell" <anders.roxell@...aro.org>,
 "Johannes Berg" <johannes@...solutions.net>
Cc: "Miri Korenblit" <miriam.rachel.korenblit@...el.com>,
 "Dan Carpenter" <dan.carpenter@...aro.org>, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 "Linaro Kernel Functional Testing" <lkft@...aro.org>
Subject: Re: [PATCH] wifi: iwlwifi: pcie: ensure RX_QUEUE_CB_SIZE fits bitfield for
 gcc-8|9

On Thu, Jun 12, 2025, at 21:33, Anders Roxell wrote:
> On 2025-06-12 17:21, Johannes Berg wrote:
>
> Would it help if I indent like this?
>
> +	/* This should just be u32_encode_bits() but gcc-8 and gcc-9 fail to build */
> +	control_flags |= FIELD_PREP(IWL_CTXT_INFO_RB_CB_SIZE,
> +				    RX_QUEUE_CB_SIZE(iwl_trans_get_num_rbds(trans)) &
> +				    FIELD_MAX(IWL_CTXT_INFO_RB_CB_SIZE));
>  	control_flags |= u32_encode_bits(rb_size, IWL_CTXT_INFO_RB_SIZE);

I still find it odd to mix FIELD_PREP() and u32_encode_bits() here,
as they do the same thing.

      Arnd