linux-kernel - Re: [PATCH net-next v2 2/2] net: bcmasp: enable GRO software interrupt coalescing by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEs5isPs68JAyjZq@MacBook-Air.local>
Date: Thu, 12 Jun 2025 23:33:14 +0300
From: Joe Damato <joe@...a.to>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: netdev@...r.kernel.org, Justin Chen <justin.chen@...adcom.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"open list:BROADCOM ASP 2.0 ETHERNET DRIVER" <bcm-kernel-feedback-list@...adcom.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: bcmasp: enable GRO software
 interrupt coalescing by default

On Wed, Jun 11, 2025 at 02:27:30PM -0700, Florian Fainelli wrote:
> Utilize netdev_sw_irq_coalesce_default_on() to provide conservative
> default settings for GRO software interrupt coalescing.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Reviewed-by: Justin Chen <justin.chen@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> index 7dc28166d337..a6ea477bce3c 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> @@ -1279,6 +1279,8 @@ struct bcmasp_intf *bcmasp_interface_create(struct bcmasp_priv *priv,
>  	ndev->hw_features |= ndev->features;
>  	ndev->needed_headroom += sizeof(struct bcmasp_pkt_offload);
>  
> +	netdev_sw_irq_coalesce_default_on(ndev);
> +
>  	return intf;

Just to make it explicit to other readers: netdev_sw_irq_coalesce_default_on
appears to be called before register_netdev, as the documentation for
netdev_sw_irq_coalesce_default_on describes.

Reviewed-by: Joe Damato <joe@...a.to>