linux-kernel - Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <426e8d83-1cc9-4812-b1c5-488d252350ec@linux.microsoft.com>
Date: Thu, 12 Jun 2025 09:34:09 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: "K . Y . Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H . Peter Anvin" <hpa@...or.com>, Vitaly Kuznetsov <vkuznets@...hat.com>,
 Paolo Bonzini <pbonzini@...hat.com>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Konstantin Taranov <kotaranov@...rosoft.com>,
 Leon Romanovsky <leon@...nel.org>, Long Li <longli@...rosoft.com>,
 Shiraz Saleem <shirazsaleem@...rosoft.com>,
 Shradha Gupta <shradhagupta@...ux.microsoft.com>,
 Maxim Levitsky <mlevitsk@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Erni Sri Satya Vennela <ernis@...ux.microsoft.com>,
 Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
 linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org, netdev@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h
 header inclusion

On 6/11/2025 6:28 PM, Sean Christopherson wrote:
> On Wed, Jun 11, 2025, Naman Jain wrote:
>> Fix below warning in Hyper-V drivers
> 
> KVM is quite obviously not a Hyper-V driver.
> 
>> that comes when kernel is compiled with W=1 option. Include export.h in
>> driver files to fix it.  * warning: EXPORT_SYMBOL() is used, but #include
>> <linux/export.h> is missing
> 
> NAK.  I agree with Heiko[*], this is absurd.  And if the W=1 change isn't reverted
> for some reason, I'd rather "fix" all of KVM in one shot, not update random files
> just because of their name.
> 
> Sorry.
> 
> [*] https://lore.kernel.org/all/20250611075533.8102A57-hca@linux.ibm.com
> 

Sure, thanks for reviewing.

Regards,
Naman

>> Signed-off-by: Naman Jain <namjain@...ux.microsoft.com>
>> ---
>>   arch/x86/kvm/hyperv.c       | 1 +
>>   arch/x86/kvm/kvm_onhyperv.c | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
>> index 24f0318c50d7..09f9de4555dd 100644
>> --- a/arch/x86/kvm/hyperv.c
>> +++ b/arch/x86/kvm/hyperv.c
>> @@ -33,6 +33,7 @@
>>   #include <linux/sched/cputime.h>
>>   #include <linux/spinlock.h>
>>   #include <linux/eventfd.h>
>> +#include <linux/export.h>
>>   
>>   #include <asm/apicdef.h>
>>   #include <asm/mshyperv.h>
>> diff --git a/arch/x86/kvm/kvm_onhyperv.c b/arch/x86/kvm/kvm_onhyperv.c
>> index ded0bd688c65..ba45f8364187 100644
>> --- a/arch/x86/kvm/kvm_onhyperv.c
>> +++ b/arch/x86/kvm/kvm_onhyperv.c
>> @@ -5,6 +5,7 @@
>>   #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>>   
>>   #include <linux/kvm_host.h>
>> +#include <linux/export.h>
>>   #include <asm/mshyperv.h>
>>   
>>   #include "hyperv.h"
>> -- 
>> 2.34.1
>>