linux-kernel - Re: [PATCH net-next v2 7/7] selftest: netconsole: add test for cmdline configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250612150542.0b4a7d71@kernel.org>
Date: Thu, 12 Jun 2025 15:05:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Shuah Khan
 <shuah@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 7/7] selftest: netconsole: add test for
 cmdline configuration

On Wed, 11 Jun 2025 07:18:56 -0700 Breno Leitao wrote:
> Add a new selftest to verify netconsole module loading with command
> line arguments. This test exercises the init_netconsole() path and
> validates proper parsing of the netconsole= parameter format.
> 
> The test:
> - Loads netconsole module with cmdline configuration instead of
>   dynamic reconfiguration
> - Validates message transmission through the configured target
> - Adds helper functions for cmdline string generation and module
>   validation
> 
> This complements existing netconsole selftests by covering the
> module initialization code path that processes boot-time parameters.
> This test is useful to test issues like the one described in [1].

I think this leaks the IP address, because if netcons_overflow.sh
runs afterwards it skips with:

#     inet 192.0.2.1/24 scope global eni370np1
# SKIP: IPs already in use. Skipping it

if netcons_overflow.sh runs first everything is fine.
-- 
pw-bot: cr