linux-kernel - Re: [PATCH net-next] net: ti: icssg-prueth: Add prp offload support to ICSSG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42ac0736-cb5a-4d99-a11c-6f861adbdb5f@ti.com>
Date: Thu, 12 Jun 2025 10:50:45 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Jakub Kicinski <kuba@...nel.org>, Himanshu Mittal <h-mittal1@...com>
CC: <pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>,
        <andrew+netdev@...n.ch>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <srk@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Roger Quadros
	<rogerq@...nel.org>, <m-malladi@...com>,
        <pratheesh@...com>, <prajith@...com>
Subject: Re: [PATCH net-next] net: ti: icssg-prueth: Add prp offload support
 to ICSSG driver



On 12/06/25 5:34 am, Jakub Kicinski wrote:
> On Tue, 10 Jun 2025 11:46:38 +0530 Himanshu Mittal wrote:
>> Add support for ICSSG PRP mode which supports offloading of:
>>  - Packet duplication and PRP trailer insertion
>>  - Packet duplicate discard and PRP trailer removal
>>
>> Signed-off-by: Himanshu Mittal <h-mittal1@...com>
>> ---
>>  drivers/net/ethernet/ti/icssg/icssg_prueth.c | 23 +++++++++++++++++++-
>>  drivers/net/ethernet/ti/icssg/icssg_prueth.h |  3 +++
>>  2 files changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> index 86fc1278127c..65883c7851c5 100644
>> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>> @@ -138,6 +138,19 @@ static struct icssg_firmwares icssg_hsr_firmwares[] = {
>>  	}
>>  };
>>  
>> +static struct icssg_firmwares icssg_prp_firmwares[] = {
>> +	{
>> +		.pru = "ti-pruss/am65x-sr2-pru0-pruprp-fw.elf",
>> +		.rtu = "ti-pruss/am65x-sr2-rtu0-pruprp-fw.elf",
>> +		.txpru = "ti-pruss/am65x-sr2-txpru0-pruprp-fw.elf",
>> +	},
>> +	{
>> +		.pru = "ti-pruss/am65x-sr2-pru1-pruprp-fw.elf",
>> +		.rtu = "ti-pruss/am65x-sr2-rtu1-pruprp-fw.elf",
>> +		.txpru = "ti-pruss/am65x-sr2-txpru1-pruprp-fw.elf",
>> +	}
>> +};
> 
> AFAIU your coworker is removing the static names, please wait until 
> the dust is settled on that:
> 
> https://lore.kernel.org/all/20250610052501.3444441-1-danishanwar@ti.com/

Yes, it's better to wait for that patch to get merged before we add new
firmware.

-- 
Thanks and Regards,
Danish