linux-kernel - Re: [PATCH v5 2/2] crypto: ti: Add driver for DTHE V2 AES Engine (ECB, CBC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b31e87f3-92b1-45fd-be62-48eccc4f0a4c@ti.com>
Date: Thu, 12 Jun 2025 11:19:23 +0530
From: T Pratham <t-pratham@...com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: "David S. Miller" <davem@...emloft.net>,
        Kamlesh Gurudasani
	<kamlesh@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Praneeth Bajjuri
	<praneeth@...com>,
        Manorit Chawdhry <m-chawdhry@...com>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] crypto: ti: Add driver for DTHE V2 AES Engine
 (ECB, CBC)

On 11/06/25 15:02, Herbert Xu wrote:
> On Tue, Jun 03, 2025 at 06:07:29PM +0530, T Pratham wrote:
>>
>> +static void dthe_cipher_exit_tfm(struct crypto_skcipher *tfm)
>> +{
>> +	struct dthe_tfm_ctx *ctx = crypto_skcipher_ctx(tfm);
>> +
>> +	ctx->keylen = 0;
>> +}
> 
> This is pointless.  Just get rid of the exit_tfm function.
> 
> Cheers,

Okay. I was under the impression that init and exit functions were mandatory. Seems like they are not. I'll remove this function.

Regards
T Pratham <t-pratham@...com>