linux-kernel - Re: [PATCH 1/2] VFS: change old_dir and new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpeguiOZJ4dZU-mc0V8bwvWoJ-Q0JubYvYPpmr-f8uguF2LQ@mail.gmail.com>
Date: Thu, 12 Jun 2025 08:10:27 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: NeilBrown <neil@...wn.name>, Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
	David Howells <dhowells@...hat.com>, Tyler Hicks <code@...icks.com>, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, 
	Amir Goldstein <amir73il@...il.com>, Kees Cook <kees@...nel.org>, 
	Joel Granados <joel.granados@...nel.org>, Namjae Jeon <linkinjeon@...nel.org>, 
	Steve French <smfrench@...il.com>, Sergey Senozhatsky <senozhatsky@...omium.org>, netfs@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, ecryptfs@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org, 
	linux-unionfs@...r.kernel.org, linux-cifs@...r.kernel.org
Subject: Re: [PATCH 1/2] VFS: change old_dir and new_dir in struct renamedata
 to dentrys

On Thu, 12 Jun 2025 at 01:38, Al Viro <viro@...iv.linux.org.uk> wrote:

> Umm...  No objections, as long as overlayfs part is correct; it seems
> to be, but I hadn't checked every chunk there...

Overlayfs parts looks okay too.

A followup would be nice (e.g. make ovl_cleanup() take a dentry for
the directory as well, etc) so that there's no need to have local
variables for both the inode and dentry of the directory.

Thanks,
Miklos