linux-kernel - Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25839448-6307-479d-a6f2-8c3ae03bbfaf@collabora.com>
Date: Thu, 12 Jun 2025 09:13:59 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Chen Ni <nichen@...as.ac.cn>, perex@...ex.cz, tiwai@...e.com,
 franta-linux@...ntovo.cz, lina+kernel@...hilina.net, livvy@...e.nu,
 sstistrup@...il.com, s@....tw
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

On 6/12/25 9:02 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  sound/usb/mixer_quirks.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 0769ecd91144..a0ffe8b559dc 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -762,9 +762,9 @@ static int snd_dualsense_jack_create(struct usb_mixer_interface *mixer,
>  
>  	mei->ih.event = snd_dualsense_ih_event;
>  	mei->ih.match = snd_dualsense_ih_match;
> -	mei->ih.connect = snd_dualsense_ih_connect,
> -	mei->ih.disconnect = snd_dualsense_ih_disconnect,
> -	mei->ih.start = snd_dualsense_ih_start,
> +	mei->ih.connect = snd_dualsense_ih_connect;
> +	mei->ih.disconnect = snd_dualsense_ih_disconnect;
> +	mei->ih.start = snd_dualsense_ih_start;
>  	mei->ih.name = name;
>  	mei->ih.id_table = mei->id_table;


Thanks for catching this!

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>