linux-kernel - Re: [PATCH] net: pfcp: fix typo in message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGHX7-P5fgFCs3cJTYERu9dLne=UADPc-dHPZ6GYvkcdmTHXwA@mail.gmail.com>
Date: Thu, 12 Jun 2025 08:38:20 +0200
From: Ruben Kelevra <rubenkelevra@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Charalampos Mitrodimas <charmitro@...teo.net>, netdev@...r.kernel.org, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] net: pfcp: fix typo in message_priority field name

Hi Jakub,

I hit it while building an out-of-tree module that reads hdr->message_priority.
Cross-compiling for a big-endian target failed for me, because of it.

That’s the only reason for the patch; net-next is fine, no need for stable.

Cheers,
Ruben

On Wed, Jun 11, 2025 at 11:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 10 Jun 2025 18:42:28 +0000 Charalampos Mitrodimas wrote:
> > > Fix 'message_priprity' typo to 'message_priority' in big endian
> > > bitfield definition. This typo breaks compilation on big endian
> > > architectures.
> > >
> > > Fixes: 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Cc: stable@...r.kernel.org # commit 6dd514f48110 ("pfcp: always set pfcp metadata")
> > > Signed-off-by: RubenKelevra <rubenkelevra@...il.com>
> >
> > I had the same issue today, happy there's a patch for this.
>
> Could y'all share more? What compilation does this break?
> The field is never used.
>
> More info about how you found the problem would be useful.
> And I believe this can go to net-next, without the CC stable
> and without the Fixes tag. Unless my grep is lying to me:
>
> net-next$ git grep message_priority
> include/net/pfcp.h:     u8      message_priority:4,
> --
> pw-bot: cr