linux-kernel - Re: [PATCH v2] nfsd: Use correct error code when decoding extents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEp6-T8Oqe2dI7of@infradead.org>
Date: Thu, 12 Jun 2025 00:00:09 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Sergey Bashirov <sergeybashirov@...il.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Christoph Hellwig <hch@...radead.org>,
	Jeff Layton <jlayton@...nel.org>, NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Konstantin Evtushenko <koevtushenko@...dex.com>
Subject: Re: [PATCH v2] nfsd: Use correct error code when decoding extents

On Wed, Jun 11, 2025 at 11:55:02PM +0300, Sergey Bashirov wrote:
>  	if (nr_iomaps < 0)
> -		return nfserrno(nr_iomaps);
> +		return cpu_to_be32(-nr_iomaps);

This still feels like an odd calling convention.  Maybe we should just
change the calling convention to return the __be32 encoded nfs errno
and have a separate output argument for the number of iomaps?

Chuck, any preference?