[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250612070656.bir2ywkwu27gxs7d@ankitchauhan-Legion-5-15ITH6>
Date: Thu, 12 Jun 2025 12:36:56 +0530
From: Ankit Chauhan <ankitchauhan2065@...il.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
On Thu, Jun 12, 2025 at 03:01:58PM +0930, Andrew Jeffery wrote:
> Hi Ankit, thanks for the fix.
>
> Regarding the subject, can you please use the prefix 'ARM: dts:
> aspeed:'? From there, I'd prefer something like:
>
> ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes
>
> On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote:
> > Fix an obvious spelling error in the dts file for Lanyang BMC.
> > This was reported by bugzilla a few years ago but never got fixed.
> >
> > Reported by: Jens Schleusener <Jens.Schleusener@...sies.org>
>
> Please make sure these tags reflect convention:
>
> https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
>
> Rather than spaces, they use `-` to separate words, so:
>
> Reported-by: ...
>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
> >
> > Signed-off-by: Ankit Chauhan <ankitchauhan2065@...il.com>
>
> Finally, all the tags should go together in the 'trailer' (final
> paragraph). There should not be an empty line between the `Closes:` tag
> and your `Signed-off-by:` tag above.
>
Hi Andrew,
Thanks for the feedback. I will make all the necessary changes and send
a v2 PATCH.
Kind regards,
Ankit Chauhan
Powered by blists - more mailing lists