linux-kernel - Re: drivers/opp/of.o: warning: objtool: _opp_table_alloc_required_tables+0x3b0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250612072937.gb3n2mh34aivabt4@vireshk-i7>
Date: Thu, 12 Jun 2025 12:59:37 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: kernel test robot <lkp@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: drivers/opp/of.o: warning: objtool:
 _opp_table_alloc_required_tables+0x3b0: stack state mismatch: reg1[22]=-1+0
 reg2[22]=-2-16

On 11-06-25, 06:19, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   f09079bd04a924c72d555cd97942d5f8d7eca98c
> commit: ff9c512041f2b405536640374ae3a3fe10efaf8b OPP: Use mutex locking guards
> date:   6 weeks ago
> config: loongarch-randconfig-002-20250611
> compiler: loongarch64-linux-gcc (GCC) 15.1.0
> reproduce (this is a W=1 build):
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506110656.WF6sPKbe-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/opp/of.o: warning: objtool: _opp_table_alloc_required_tables+0x3b0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-16

Hi,

I am not really sure what's really wrong with the change here:

@@ -201,9 +191,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
                 * The OPP table is not held while allocating the table, take it
                 * now to avoid corruption to the lazy_opp_tables list.
                 */
-               mutex_lock(&opp_table_lock);
+               guard(mutex)(&opp_table_lock);
                list_add(&opp_table->lazy, &lazy_opp_tables);
-               mutex_unlock(&opp_table_lock);
        }
 }

Can someone help ?

-- 
viresh