linux-kernel - Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ecvpv2mf.wl-tiwai@suse.de>
Date: Thu, 12 Jun 2025 09:30:00 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Takashi Iwai <tiwai@...e.de>,
	Chen Ni <nichen@...as.ac.cn>,
	perex@...ex.cz,
	tiwai@...e.com,
	franta-linux@...ntovo.cz,
	lina+kernel@...hilina.net,
	livvy@...e.nu,
	sstistrup@...il.com,
	s@....tw,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon

On Thu, 12 Jun 2025 09:22:36 +0200,
Cristian Ciocaltea wrote:
> 
> On 6/12/25 9:52 AM, Takashi Iwai wrote:
> > On Thu, 12 Jun 2025 08:02:28 +0200,
> > Chen Ni wrote:
> >>
> >> Replace comma between expressions with semicolons.
> >>
> >> Using a ',' in place of a ';' can have unintended side effects.
> >> Although that is not the case here, it is seems best to use ';'
> >> unless ',' is intended.
> >>
> >> Found by inspection.
> >> No functional change intended.
> >> Compile tested only.
> >>
> >> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> > 
> > Thanks, applied now.
> > 
> > At the next time, though, it'd be appreciated if you can put the
> > proper Fixes tag.
> 
> Considering this is not really a functional change, I think a 
> Fixes tag would trigger an unnecessary backport, wouldn't it?

If it were in the old released kernels, I wouldn't be bothered,
either.  But this is still in staging for the next, and having Fixes
tag will help to track if someone tries to backport patches.
Otherwise the code differs and may give conflicts in further
backports.


thanks,

Takashi