linux-kernel - Re: [PATCH 02/11] HID: playstation: Add spaces around arithmetic operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3aaf7e6f-7b81-408a-bcdd-de835b3ca7dc@collabora.com>
Date: Thu, 12 Jun 2025 11:30:34 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Roderick Colenbrander <thunderbird2k@...il.com>
Cc: Roderick Colenbrander <roderick.colenbrander@...y.com>,
 Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Henrik Rydberg <rydberg@...math.org>, kernel@...labora.com,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] HID: playstation: Add spaces around arithmetic
 operators

Hi Roderick,

On 6/10/25 7:19 AM, Roderick Colenbrander wrote:
> Hi Christian,
> 
> We could change some of this. I guess checkpatch changed some output
> since original submission or is more strict in --strict mode. Though I
> have an opinion on these kind of silly patches.

As I've already mentioned earlier, disabling the strict mode would be
an error-prone workflow which I try to avoid as much as possible.

And I'd still prefer to do additional cleanup work and provide these 
kind of "silly" patches, rather then minimizing my diffs and grow the
overall inconsistency.

Thanks,
Cristian