linux-kernel - Re: [PATCH] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174971912969.3783933.11490887989460650891.b4-ty@kernel.org>
Date: Thu, 12 Jun 2025 05:05:29 -0400
From: Leon Romanovsky <leon@...nel.org>
To: Jason Gunthorpe <jgg@...pe.ca>, Patrisious Haddad <phaddad@...dia.com>, 
 Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, 
 Christian Göttsche <cgzones@...glemail.com>, 
 Serge Hallyn <serge@...lyn.com>, Chiara Meiohas <cmeiohas@...dia.com>, 
 Al Viro <viro@...iv.linux.org.uk>, linux-rdma@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: reduce stack usage in
 mlx5_ib_ufile_hw_cleanup


On Tue, 10 Jun 2025 11:28:42 +0200, Arnd Bergmann wrote:
> This function has an array of eight mlx5_async_cmd structures, which
> often fits on the stack, but depending on the configuration can
> end up blowing the stack frame warning limit:
> 
> drivers/infiniband/hw/mlx5/devx.c:2670:6: error: stack frame size (1392) exceeds limit (1280) in 'mlx5_ib_ufile_hw_cleanup' [-Werror,-Wframe-larger-than]
> 
> Change this to a dynamic allocation instead. While a kmalloc()
> can theoretically fail, a GFP_KERNEL allocation under a page will
> block until memory has been freed up, so in the worst case, this
> only adds extra time in an already constrained environment.
> 
> [...]

Applied, thanks!

[1/1] RDMA/mlx5: reduce stack usage in mlx5_ib_ufile_hw_cleanup
      https://git.kernel.org/rdma/rdma/c/b26852daaa83f5

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>