linux-kernel - Re: [PATCH] rust: cast to the proper type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250612.094853.1245231705823615660.fujita.tomonori@gmail.com>
Date: Thu, 12 Jun 2025 09:48:53 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: tamird@...il.com
Cc: aliceryhl@...gle.com, fujita.tomonori@...il.com, tmgross@...ch.edu,
 ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
 a.hindborg@...nel.org, dakr@...nel.org, davem@...emloft.net,
 andrew@...n.ch, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: cast to the proper type

On Wed, 11 Jun 2025 09:41:08 -0400
Tamir Duberstein <tamird@...il.com> wrote:

>> > > +            DuplexMode::Full => bindings::DUPLEX_FULL,
>> > > +            DuplexMode::Half => bindings::DUPLEX_HALF,
>> > > +            DuplexMode::Unknown => bindings::DUPLEX_UNKNOWN,
>> > > +        } as crate::ffi::c_int;
>> >
>> > This file imports the prelude, so this can just be c_int without the
>> > crate::ffI:: path.
>>
>> This has come up a few times now; should we consider denying
>> unused_qualifications?
>>
>> https://doc.rust-lang.org/stable/nightly-rustc/rustc_lint/builtin/static.UNUSED_QUALIFICATIONS.html
> 
> I should point out also that every reference to crate::ffi::c_int in
> this file is fully qualified, so I think this should be a separate
> change.

I can take care of this file.

Thanks,