linux-kernel - Re: [PATCH v6 0/6] media: Fix coccinelle warning/errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52f863d6-0c07-4290-a959-7725b9889344@kernel.org>
Date: Thu, 12 Jun 2025 10:22:57 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Ricardo Ribalda <ribalda@...omium.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Hans Verkuil <hverkuil@...all.nl>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, Kosta Stefanov <costa.stephanoff@...il.com>
Subject: Re: [PATCH v6 0/6] media: Fix coccinelle warning/errors

On 11/01/2025 09:55, Ricardo Ribalda wrote:
> These is the last set of patches to fix all the relevant patchwork
> warnings (TM).
> 
> --
> 
> ---
> Changes in v6:
> - Improve comments for tda10048, thanks Kosta.
> - Link to v5: https://lore.kernel.org/r/20250107-fix-cocci-v5-0-b26da641f730@chromium.org
> 
> Changes in v5:
> - venus: Ignore fps > 240
> - venus: Clamp invalid fps instead of -EINVAL
> - Link to v4: https://lore.kernel.org/r/20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org
> 
> Changes in v4:
> - Remove all merged patches
> - Improve commit messages.
> - media: Remove timeperframe from inst
> - Ignore 0 fps (Thanks Hans)
> - Link to v3: https://lore.kernel.org/r/20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org
> 
> Changes in v3: Thanks Bryan, Dan, Markus, Sakary and Hans
> - Improve commit messages.
> - Use div64_u64 when possible
> - Link to v2: https://lore.kernel.org/r/20240419-fix-cocci-v2-0-2119e692309c@chromium.org
> 
> Changes in v2:
> - Remove all the min() retval, and send a patch for cocci:  https://lore.kernel.org/lkml/20240415-minimax-v1-1-5feb20d66a79@chromium.org/T/#u
> - platform_get_irq() cannot return 0, fix that (Thanks Dan).
> - Fix stb0800 patch. chip_id can be 0 (Thanks Dan).
> - Use runtime (IS_ENABLED), code looks nicer. (Thanks Dan).
> - Do not replace do_div for venus (Thanks Dan).
> - Do not replace do_div for tda10048 (Thanks Dan).
> - Link to v1: https://lore.kernel.org/r/20240415-fix-cocci-v1-0-477afb23728b@chromium.org
> 
> To: Mauro Carvalho Chehab <mchehab@...nel.org>
> To: Stanimir Varbanov <stanimir.k.varbanov@...il.com>
> To: Vikash Garodia <quic_vgarodia@...cinc.com>
> To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> To: Hans Verkuil <hverkuil@...all.nl>
> Cc: linux-media@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-arm-msm@...r.kernel.org
> 
> ---
> Ricardo Ribalda (6):
>        media: dvb-frontends: tda10048: Make the range of z explicit.
>        media: venus: vdec: Clamp parm smaller than 1fps and bigger than 240.
>        media: venus: venc: Clamp parm smaller than 1fps and bigger than 240
>        media: venus: Remove timeperframe from inst
>        media: venus: venc: Make the range of us_per_frame explicit
>        media: venus: vdec: Make the range of us_per_frame explicit
> 
>   drivers/media/dvb-frontends/tda10048.c   |  8 +++++++-
>   drivers/media/platform/qcom/venus/core.h |  4 ++--
>   drivers/media/platform/qcom/venus/vdec.c | 23 +++++++++++------------
>   drivers/media/platform/qcom/venus/venc.c | 24 +++++++++++-------------
>   4 files changed, 31 insertions(+), 28 deletions(-)
> ---
> base-commit: 4db312bbce420e3f874302549db072211e03c569
> change-id: 20240415-fix-cocci-2df3ef22a6f7
> 
> Best regards,

@Vikash || @Dikshita

Are you happy enough with these changes for venus ?

---
bod