linux-kernel - Re: (subset) [PATCH] mfd: fix building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174972251660.411546.11712272234120780.b4-ty@kernel.org>
Date: Thu, 12 Jun 2025 11:01:56 +0100
From: Lee Jones <lee@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>, 
 "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Lee Jones <lee@...nel.org>, 
 Aaro Koskinen <aaro.koskinen@....fi>, 
 Andreas Kemnade <andreas@...nade.info>, Kevin Hilman <khilman@...libre.com>, 
 Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>, 
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
 Chen Ni <nichen@...as.ac.cn>, linux-kernel@...r.kernel.org, 
 linux-omap@...r.kernel.org
Subject: Re: (subset) [PATCH] mfd: fix building without CONFIG_OF

On Tue, 20 May 2025 17:40:43 +0200, Arnd Bergmann wrote:
> Using the of_fwnode_handle() means that local 'node' variables are unused
> whenever CONFIG_OF is disabled for compile testing:
> 
> drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
> drivers/mfd/88pm860x-core.c:576:29: error: unused variable 'node' [-Werror=unused-variable]
>   576 |         struct device_node *node = i2c->dev.of_node;
>       |                             ^~~~
> drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
> drivers/mfd/max8925-core.c:659:29: error: unused variable 'node' [-Werror=unused-variable]
>   659 |         struct device_node *node = chip->dev->of_node;
>       |                             ^~~~
> drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
> drivers/mfd/twl4030-irq.c:679:46: error: unused variable 'node' [-Werror=unused-variable]
>   679 |         struct                  device_node *node = dev->of_node;
>       |                                              ^~~~
> 
> [...]

Applied, thanks!

[1/1] mfd: fix building without CONFIG_OF
      commit: fc5f017a71d08eea3983762ce57d27e5bc300db1

--
Lee Jones [李琼斯]