lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aEqmwLRzpNDlNzoK@e110455-lin.cambridge.arm.com>
Date: Thu, 12 Jun 2025 11:06:56 +0100
From: Liviu Dudau <liviu.dudau@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drm/arm/malidp: Silence informational message

Hi,

On Fri, May 23, 2025 at 08:40:41AM +0200, Alexander Stein wrote:
> When checking for unsupported expect an error is printed every time.
> This spams the log for platforms where this is expected, e.g. ls1028a
> having a Vivante (etnaviv) GPU and Mali display processor.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>

Sorry for the delay in replying, I was on holiday when you've sent the patch and
I've only found it today.

Patch looks sensible, so Reviewed-by: Liviu Dudau <liviu.dudau@....com>

I will push the patch today into drm-misc-next.

Best regards,
Liviu

> ---
> Every time glmark2-es2-wayland is started on a downstream kernel raises the error:
> > [drm:malidp_format_mod_supported [mali_dp]] *ERROR* Unknown modifier (not Arm)
> 
>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 34547edf1ee3c..87f2e5ee87907 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -159,7 +159,7 @@ bool malidp_format_mod_supported(struct drm_device *drm,
>  	}
>  
>  	if (!fourcc_mod_is_vendor(modifier, ARM)) {
> -		DRM_ERROR("Unknown modifier (not Arm)\n");
> +		DRM_DEBUG_KMS("Unknown modifier (not Arm)\n");
>  		return false;
>  	}
>  
> -- 
> 2.43.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ