lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <85594b9d-b4fe-4cfd-ae3a-07901b9e27df@quicinc.com>
Date: Thu, 12 Jun 2025 16:12:28 +0530
From: Gaurav Kohli <quic_gkohli@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@....qualcomm.com>
CC: <amitk@...nel.org>, <daniel.lezcano@...aro.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <andersson@...nel.org>, <konradybcio@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_manafm@...cinc.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for
 QCS615 SoC



On 6/11/2025 8:17 PM, Konrad Dybcio wrote:
> On 6/11/25 4:19 PM, Dmitry Baryshkov wrote:
>> On Wed, Jun 11, 2025 at 04:08:57PM +0200, Konrad Dybcio wrote:
>>> On 6/11/25 8:37 AM, Gaurav Kohli wrote:
>>>> Add TSENS and thermal devicetree node for QCS615 SoC.
>>>>
>>>> Signed-off-by: Gaurav Kohli <quic_gkohli@...cinc.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> +	thermal-zones {
>>>> +		aoss-thermal {
>>>> +			thermal-sensors = <&tsens0 0>;
>>>> +
>>>> +			trips {
>>>> +				trip-point0 {
>>>> +					temperature = <110000>;
>>>> +					hysteresis = <5000>;
>>>> +					type = "passive";
>>>
>>> All of the passive trip points you added that aren't bound to any
>>> cooling devices should be critical instead (otherwise they're not
>>> doing anything)
>>>
>>> otherwise, looks good
>>
thanks for the review & comment, let me send 3rd patch with critical for 
all trips.
>> Don't we need cooling-maps for CPU thermal zones?
> 
> no, we have lmh
> 
> Konrad


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ