linux-kernel - Re: [PATCH] x86: Fix build warnings about export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc7AO_sRgB1Nj6CevbseMFyv5ku8ZS3PwzAuAgysKVxNg@mail.gmail.com>
Date: Thu, 12 Jun 2025 14:10:15 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Juergen Gross <jgross@...e.com>
Cc: Zhenghan Cheng <chengzhenghan@...ontech.com>, tglx@...utronix.de, mingo@...hat.com, 
	bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, 
	mario.limonciello@....com, yazen.ghannam@....com, jpoimboe@...nel.org, 
	tony.luck@...el.com, jarkko@...nel.org, bhelgaas@...gle.com, 
	pbonzini@...hat.com, oleg@...hat.com, jbaron@...mai.com, ning.sun@...el.com, 
	seanjc@...gle.com, luto@...nel.org, andy@...nel.org, jim.cromie@...il.com, 
	kirill.shutemov@...ux.intel.com, hpa@...or.com, 
	pawan.kumar.gupta@...ux.intel.com, vkuznets@...hat.com, rostedt@...dmis.org, 
	ardb@...nel.org, thomas.lendacky@....com, nikunj@....com, 
	ashish.kalra@....com, kees@...nel.org, alexandre.chartre@...cle.com, 
	rppt@...nel.org, steve.wahl@....com, jirislaby@...nel.org, 
	apatel@...tanamicro.com, bvanassche@....org, ptsm@...ux.microsoft.com, 
	Jonathan.Cameron@...wei.com, beata.michalska@....com, xin@...or.com, 
	davydov-max@...dex-team.ru, ravi.bangoria@....com, joel.granados@...nel.org, 
	ffmancera@...eup.net, kprateek.nayak@....com, akpm@...ux-foundation.org, 
	bhe@...hat.com, brgerst@...il.com, coxu@...hat.com, dmaluka@...omium.org, 
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org, 
	linux-sgx@...r.kernel.org, kvm@...r.kernel.org, 
	virtualization@...ts.linux.dev, tboot-devel@...ts.sourceforge.net, 
	nouveau@...ts.freedesktop.org, linux-coco@...ts.linux.dev, 
	xen-devel@...ts.xenproject.org, Huacai Chen <chenhuacai@...ngson.cn>, 
	Zhenghan Cheng <your_email@...mple.com>
Subject: Re: [PATCH] x86: Fix build warnings about export.h

On Thu, Jun 12, 2025 at 1:19 PM Juergen Gross <jgross@...e.com> wrote:
>
> On 12.06.25 11:32, Zhenghan Cheng wrote:
> > After commit a934a57a42f64a4 ("scripts/misc-check:
> > check missing #include <linux/export.h> when W=1")
> > and commit 7d95680d64ac8e836c ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1"),
> > we get some build warnings with W=1,such as:
> >
> > arch/x86/coco/sev/core.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > arch/x86/crypto/aria_aesni_avx2_glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > arch/x86/kernel/unwind_orc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > arch/x86/kvm/hyperv.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > arch/x86/events/intel/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> > arch/x86/events/zhaoxin/core.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> > arch/x86/kernel/crash.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> > arch/x86/kernel/devicetree.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> >
> > so fix these build warnings for x86.
> >
> > Signed-off-by: "Zhenghan Cheng" <chengzhenghan@...ontech.com>
> > Suggested-by: "Huacai Chen" <chenhuacai@...ngson.cn>
>
> For Xen and paravirt:
>
> Acked-by: Juergen Gross <jgross@...e.com>
>
> Your patch is looking a little bit strange, as the list of modified files
> is located between the patch hunks, followed by another "Signed-off-by:".

Indeed.
And at bare minimum please split at least to two:
1) adding export.h;
2) removing export.h.


-- 
With Best Regards,
Andy Shevchenko