linux-kernel - Re: [PATCH net-next 2/8] net: hns3: add the hns3_get_ae

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEq3DgCDh98Deidl@mev-dev.igk.intel.com>
Date: Thu, 12 Jun 2025 13:16:40 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shenjian15@...wei.com, wangpeiyang1@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] net: hns3: add the hns3_get_ae_dev() helper

On Thu, Jun 12, 2025 at 10:13:11AM +0800, Jijie Shao wrote:
> This patch introduces a hns3_get_ae_dev() helper to reduce the unnecessary
> middle layer conversion. Apply it to the whole HNS3 driver.
> The former discusstion can be checked from the link.

The definition already exist, so more like "use hns3_get_ae_dev()
wherever possible".

> 
> Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230310081404.947-1-lanhao@huawei.com/

I think the comment is about going from netdev to your private
hnae3_ae_dev. You need hnae3_netdev_to_dev/pf/whatever().

Using already defined helper is fine, just please change the commit
message/title.

> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

[...]